Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toString does not match V8 stack trace format #22

Closed
niftylettuce opened this issue Sep 13, 2019 · 2 comments
Closed

toString does not match V8 stack trace format #22

niftylettuce opened this issue Sep 13, 2019 · 2 comments
Labels
a:feature

Comments

@niftylettuce
Copy link
Contributor

Could we modify toString so that it closely matches https://v8.dev/docs/stack-trace-api#appendix%3A-stack-trace-format instead of current format?

Calling Error.prepareStackTrace(err, stackframes) does not give proper output.
@niftylettuce niftylettuce mentioned this issue Sep 13, 2019
Closed
@niftylettuce
Copy link
Contributor Author

Here is how Node prepares it:

https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

@niftylettuce niftylettuce mentioned this issue Sep 13, 2019
Merged
@eriwen
Copy link
Member

eriwen commented Sep 14, 2019

This is fixed by #23. Thanks @niftylettuce!

@eriwen eriwen closed this as completed Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eriwen @niftylettuce