Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserify build now failing in browser #36

Closed
pocesar opened this issue Apr 24, 2016 · 1 comment
Closed

Browserify build now failing in browser #36

pocesar opened this issue Apr 24, 2016 · 1 comment

Comments

@pocesar
Copy link

pocesar commented Apr 24, 2016

Seems that a dependency (source-map) is breaking this library

Steps to Reproduce (for bugs)

  1. Install stacktrace-gps through npm
  2. Import the file stacktrace-gps inside a javascript es6 file
  3. Run browserify and bundle the needed libraries
  4. Load the bundle in the browser
  5. Console shows an error ReferenceError: identity is not defined pointing to https://github.com/mozilla/source-map/blob/7c4905497b5f0a62fd6a3d3f786ba8eac0db4615/lib/util.js#L258

Your Environment

  • stacktrace.js version: 1.1.1
  • Browser Name and version: Firefox 45.0.2
  • Operating System and version (desktop or mobile): Windows 10 x64
  • Link to your project: private
@pocesar
Copy link
Author

pocesar commented Apr 25, 2016

The culprit is this merge mozilla/source-map@f7acd59

The functions inside blocks are not hoisted in Firefox

@eriwen eriwen closed this as completed in 4aaa37a May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pocesar