Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Warning when using TextField #38

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix Warning when using TextField #38

merged 1 commit into from
Oct 8, 2018

Conversation

LironEr
Copy link
Contributor

@LironEr LironEr commented Oct 8, 2018

Sorry, didn't notice that on the first PR
Resolve #37

@cliedeman cliedeman merged commit 00ba233 into stackworx:master Oct 8, 2018
@cliedeman
Copy link
Collaborator

Unfortunately, ts didn't catch this because getIn returns the any type. I have added some more types to the functions so we can hopefully catch things like this more easily but we will just have to be wary when dealing with getIn, errors and touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliedeman cliedeman cliedeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LironEr @cliedeman