Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The calculation of log_q in bgcn.py #1

Closed
MatoCom opened this issue Dec 17, 2021 · 2 comments
Closed

The calculation of log_q in bgcn.py #1

MatoCom opened this issue Dec 17, 2021 · 2 comments

Comments

@MatoCom
Copy link

MatoCom commented Dec 17, 2021

Hi,
In gpn/models/bgcn.py line 110,
I think there is a small mistake.
Shouldn't it be like self.conv_1.log_q + self.conv_2.log_q?
Thanks for reading.

@MatoCom
Copy link
Author

MatoCom commented Dec 20, 2021

Also, there seems to be a typing mistake at gpn/nn/transductive_graph_engine.py line 209
results[s] = {**results[s], **ood_results[s]}

stadlmax added a commit that referenced this issue Dec 20, 2021
@stadlmax
Copy link
Owner

Hi,
thank you for spotting those typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants