Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test logical xor stairs 1 #106

Merged
merged 3 commits into from Sep 12, 2021

Conversation

amagee
Copy link
Contributor

@amagee amagee commented Sep 12, 2021

Seems to do what was asked for in the ticket, let me know if you want anything more / different.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #106 (b87c6d2) into master (e0a45c0) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   94.36%   94.42%   +0.06%     
==========================================
  Files          32       32              
  Lines        1561     1561              
==========================================
+ Hits         1473     1474       +1     
+ Misses         88       87       -1     
Impacted Files Coverage Δ
staircase/core/ops/logical.py 92.10% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a45c0...b87c6d2. Read the comment docs.

@venaturum
Copy link
Collaborator

venaturum commented Sep 12, 2021

Great, thanks @amagee

Can we have an additional, but very similar test, which checks:

(s3_fix ^ ~s3_fix).identical(1)

The ~ operator is a "not" operator.

@venaturum venaturum merged commit 8356e53 into staircase-dev:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Missing test for Stairs.logical_xor for Stairs over float domain
3 participants