Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ability to override Release.Namespace for target namespace #365

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

callum-stakater
Copy link

Changing

namespace: {{ .Release.Namespace }}

to

namespace: {{ .Values.namespace | default .Release.Namespace }}

To add flexibility to deploy to its own namespace when used in an umbrella chart concept

@stakater-user
Copy link
Contributor

@callum-stakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@callum-stakater Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-365-0ef5e756

@TehreemNisa TehreemNisa merged commit 0ef6dcb into master Dec 7, 2022
@rasheedamir rasheedamir deleted the make-namespace-configurable branch January 5, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants