chore: listen on only 9090 for /metrics and /live #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d3adb5 can you please rebase from the upstream master so that the pipeline can pass? |
Previously, 9091 and 9090 both led to the same web server, meaning both /metrics and /live were reachable and fully functional through both. This commit changes that so that only port 9090 is used for both. Closes stakater#381.
d3adb5
force-pushed
the
chore/stop-listening-on-9091
branch
from
b401e6a
to
2f8999e
Compare
|
@d3adb5 Image is available for testing. |
faizanahmad055
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports 9091 and 9090 both lead to the same web server, meaning both /metrics and /live are reachable and fully functional through both. This PR changes that so that only port 9090 is used for both.
Closes #381.