Add --auto-reload-all flag #487
Conversation
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
from
dce599e
to
ffedbaf
Compare
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
from
fd7e66c
to
5db6edc
Compare
|
@itaispiegel Image is available for testing. |
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
from
5db6edc
to
97b0e6a
Compare
|
@itaispiegel Image is available for testing. |
|
@itaispiegel Thank you for the contribution, the PR looks good. Can you please also write some test cases here: https://github.com/stakater/Reloader/blob/master/internal/pkg/handler/upgrade_test.go. You can write some scenarios from your last commit where you can test if the reload-all is set to true then you reload more than one deployment upon a config map change. Having at least one positive and one negative test case should be enough :) |
|
@faizanahmad055 Great! I'll work on it this week and will keep in touch with you :) |
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
2 times, most recently
from
5f45814
to
67ac0f6
Compare
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
from
67ac0f6
to
f29cc82
Compare
itaispiegel
force-pushed
the
feature/auto-reload-all
branch
from
f29cc82
to
b9e24b3
Compare
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
|
@itaispiegel Yikes! You better fix it before anyone else finds out! Build has Failed! |
|
@itaispiegel Image is available for testing. |
|
@karl-johan-grahn Image is available for testing. |
This is my PR for issue #478.
I added the flag
--auto-reload-all, which commands the controller to reload all resources when their configmaps/secrets change, unless they have theautoannotation set tofalse(or an undefined value).I'd be glad to get feedback on this, so please tell me if the documentation isn't clear enough, or if you think this should be implemented differently.