toMongoQuery

[sarkistlt]

lets say I have a rule:
can('read', ['products'], { tid: 'someId' })
then when I'm using:
toMongoQuery(rules)

it returns { '$or': [ { tid: 'someId' } ] }, shouldn't it just be { tid: 'someId' } ?

[stalniy]

Yes, it could be. But this function doesn't do optimisation. It just follows the general rule: all regular rules are OR-ed.

So, in your case you have only 1 rules that's why they are identical. It's possible to optimise this if it's important for you. Just to check if $or contains only 1 element and there are no $and statements

[sarkistlt]

thanks for quick response, so if it will be can('read', ['products'], { id: 'someId', tid: 'someId' }), it will generate, { '$or': [ { id: 'someId', tid: 'someId' } ] }?
but in that case statement will be true if at least one if id or tid is matching but not both correct?

[stalniy]

No, $or works this way:

// this is equivalent  of
// (a === 1 && b === 2 ) || c === 3
{
  $or: [{ a: 1, b: 2 }, { c: 3 }]
}

Update: so in your case it will be the same as id === "someId" && tid === "someId

[sarkistlt]

I see, ok thanks, that work for me

[stalniy]

You are welcome! :)