Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Mongoose typings #639

Merged
merged 7 commits into from Jul 29, 2022
Merged

Conversation

qqilihq
Copy link
Contributor

@qqilihq qqilihq commented Jul 6, 2022

Closes #634

* Allow to use without `extends Document` syntax
* Requires at least Mongoose 6.0.13
* See stalniy#634
@stalniy
Copy link
Owner

stalniy commented Jul 7, 2022

Looks good. Thank you! I need to test whether this doesn't introduce a breaking change due to interface change. at first look, all should be good

@ayush-goyal
Copy link

Any update on this?

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #639 (d9855b8) into master (e174b87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          32       32           
  Lines         716      716           
  Branches      174      174           
=======================================
  Hits          671      671           
  Misses         13       13           
  Partials       32       32           
Impacted Files Coverage Δ
packages/casl-mongoose/src/accessible_fields.ts 95.23% <ø> (ø)
packages/casl-mongoose/src/accessible_records.ts 80.00% <100.00%> (ø)
packages/casl-mongoose/src/mongo.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@stalniy
Copy link
Owner

stalniy commented Jul 29, 2022

as peerDependency version was increased, I need to release a major version of casl/mongoose. Because technically it's a BC

@stalniy stalniy merged commit f5273e3 into stalniy:master Jul 29, 2022
@stalniy
Copy link
Owner

stalniy commented Jul 29, 2022

@qqilihq nice work! Thank you very much for the contribution! Sorry for the super long review.

@stalniy
Copy link
Owner

stalniy commented Jul 29, 2022

released in @casl/mongoose@7.0.0

@qqilihq
Copy link
Contributor Author

qqilihq commented Jul 31, 2022

@stalniy Great, thank you so much, highly appreciated! Awesome lib, keep it up!

@SteadEXE
Copy link

SteadEXE commented Aug 8, 2022

I was waiting for it. @stalniy you rocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongoose with Typescript without “extends Document”
5 participants