Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'use strict' causing error deep in dependency chain #53

Closed
dobrite opened this issue Dec 31, 2014 · 3 comments
Closed

'use strict' causing error deep in dependency chain #53

dobrite opened this issue Dec 31, 2014 · 3 comments

Comments

@dobrite
Copy link
Contributor

dobrite commented Dec 31, 2014

This commit of error in 4.3.0 causes an error when in strict mode:

Uncaught TypeError: Cannot assign to read only property 'name' of function createError(opts) {
            var result = new Error()... <more>

The line is here.

Assigning the name property of a function is usually a no-op (non-standard though) but in strict mode it throws.

error is a dependency of virtual-dom.

This is an error that happens when trying to run the example code in the README under chrome with webpack.

I'm thinking the issue might lay with error but am unsure. I filed an issue there too. 😄

@staltz
Copy link
Member

staltz commented Dec 31, 2014

If you use a deep 'use strict' then these problems pop up. I don't think we have any alternative than wait for a fix in the dependency.

FYI, the README example is the same as this: https://github.com/staltz/cycle/blob/master/examples/hello/hello.js

@dobrite
Copy link
Contributor Author

dobrite commented Dec 31, 2014

Closing... will carry on conversation in the error repo.

Thanks for taking a look at this!

Happy New Year! 🎉

@dobrite dobrite closed this as completed Dec 31, 2014
@sunwukung
Copy link

Just for posterity, I raised this issue after encountering the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants