Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'breaks' to geom_histogram #148

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Pass 'breaks' to geom_histogram #148

merged 2 commits into from
Jun 1, 2018

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Apr 30, 2018

This PR just adds a breaks argument to histograms that can be used as an alternative to binwidth. Turns out to be useful sometimes.

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #148 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   98.78%   98.79%   +<.01%     
==========================================
  Files          30       30              
  Lines        3879     3891      +12     
==========================================
+ Hits         3832     3844      +12     
  Misses         47       47
Impacted Files Coverage Δ
R/mcmc-distributions.R 100% <ø> (ø) ⬆️
R/mcmc-diagnostics-nuts.R 100% <ø> (ø) ⬆️
R/ppc-test-statistics.R 99.41% <100%> (ø) ⬆️
R/ppc-errors.R 99.51% <100%> (ø) ⬆️
R/mcmc-diagnostics.R 97.63% <100%> (+0.02%) ⬆️
R/mcmc-recover.R 100% <100%> (ø) ⬆️
R/ppc-distributions.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5328b...4b03a56. Read the comment docs.

@jgabry jgabry requested a review from tjmahr June 1, 2018 17:58
@jgabry
Copy link
Member Author

jgabry commented Jun 1, 2018

@tjmahr I requested your review on this to keep with best practice, but I know you're short on time these days and this is a super simple PR, so if you want me to just merge it that's fine. Otherwise review it whenever you have the chance, but no rush.

@tjmahr tjmahr merged commit 72ff752 into master Jun 1, 2018
@tjmahr tjmahr deleted the histogram-breaks-arg branch June 1, 2018 18:03
@tjmahr
Copy link
Collaborator

tjmahr commented Jun 1, 2018

Yup, super simple PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants