Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ppc_loo_pit_overlay() and ppc_loo_pit_qq() #167

Merged
merged 2 commits into from
Oct 2, 2018
Merged

fix ppc_loo_pit_overlay() and ppc_loo_pit_qq() #167

merged 2 commits into from
Oct 2, 2018

Conversation

tjmahr
Copy link
Collaborator

@tjmahr tjmahr commented Sep 18, 2018

This pull request fixes #166. The problems are described in that issue, and the diagnosis of the problems and their fixes are described there too. This pull request also the following warnings raised by testthat

test-ppc-loo.R:32: warning: ppc_loo_pit_overlay returns ggplot object
no non-missing arguments to min; returning Inf

test-ppc-loo.R:32: warning: ppc_loo_pit_overlay returns ggplot object
no non-missing arguments to max; returning -Inf

I don't know have a good statistical sense of what PIT is, and I didn't have any reference images for what these plots are supposed to look in general, so I would like @jgabry to review the changes here.

@tjmahr tjmahr requested a review from jgabry September 18, 2018 14:49
@jgabry
Copy link
Member

jgabry commented Oct 2, 2018

@tjmahr Sorry for the delay on this. These changes look good to me. Thanks for fixing this!

@jgabry jgabry merged commit 645c34a into master Oct 2, 2018
@tjmahr tjmahr deleted the issue-166 branch October 2, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ppc_loo_pit_overlay() doesn't draw anything and ppc_loo_pit_qq() fails
2 participants