Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha argument to mcmc_hist and mcmc_dens #244

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Oct 23, 2020

As requested in #237, this PR adds argument alpha to mcmc_hist() and mcmc_dens() so that users can control the fill transparency. Also added visual tests.

@jgabry jgabry requested a review from tjmahr October 23, 2020 19:29
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #244 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          32       32           
  Lines        4112     4116    +4     
=======================================
+ Hits         4044     4048    +4     
  Misses         68       68           
Impacted Files Coverage Δ
R/mcmc-distributions.R 99.44% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8786298...255f31d. Read the comment docs.

@jgabry
Copy link
Member Author

jgabry commented Oct 5, 2021

Merging this as part of my effort to clear out small old PRs that have been piling up.

@jgabry jgabry merged commit e36f040 into master Oct 5, 2021
@jgabry jgabry deleted the mcmc-hist-dens-alpha branch October 5, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants