-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppc_violin_grouped: plot y as violin, too #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 100% 99.69% -0.31%
==========================================
Files 28 28
Lines 2918 3274 +356
==========================================
+ Hits 2918 3264 +346
- Misses 0 10 +10
Continue to review full report at Codecov.
|
Thanks! I like it. Now I'm wondering if it's worth offering both options (y
as violin, y as points) or just going with the violin. Or perhaps both at
the same time. When there is a lot of data the points probably aren't that
useful, but when y doesn't contain too many observations I do think seeing
the actual points can be helpful.
|
If you decide to have an option for showing the points, it would be useful to add some jitter in x direction, so that it's possible to see if there are several overlapping y values. This will work also for small number of observations. |
Good idea. In the version with points I'll definitely jitter them a bit
horizontally.
…On Tue, Feb 28, 2017 at 5:35 PM Aki Vehtari ***@***.***> wrote:
If you decide to have an option for showing the points, it would be useful
to add some jitter in x direction, so that it's possible to see if there
are several overlapping y values. This will work also for small number of
observations.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHb4Q4sT36RTCgOb5XfAsmQSGruh3N8rks5rhKFMgaJpZM4MOSb6>
.
|
Cool. I'll implement an option that let's the user specify if he/she wants to see y as violin, jittered points, or both, in the next week or so. Regarding the documentation: Where would I need to put the description of the additional options so that it lands in the documentation of |
Great, thanks! The documentation for a new argument to #' @param argname One or several sentences describing what the argument is used for. where Once you add that you can run devtools::document()
devtools::load_all()
?ppc_violin_grouped and you should see the updated documentation. |
Just added the jittered points and an option to toggle between plotting |
I have some small changes I want to make but this looks good! I'm going to merge it now and then I'll make the changes, which is probably easier than me making commits to your branch |
I plotted a reaction time analysis using ppc_violin_grouped and got this:
However, I personally find this plot more informative as it shows the density of the empirical data also:
I created a pull request to deliver the solution to my problem instead of just opening an issue and
complaining
. Possibly, however, there are reasons out of my knowledge why the data is plotted asgeom_point
and notgeom_violin
.I'm also not sure about any possible conventions regarding the plotting style of data. I found the current style easy to see for my example.