use shortpath and cleanup #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are simple so I will merge when/if tests pass. |
bbbales2
reviewed
Mar 5, 2021
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ### Bug fixes | |||
|
|
|||
| * Fixed bug with spaces in path to the temporary folder on Windows. (#460) | |||
There was a problem hiding this comment.
Lol that's a pretty good gotcha
There was a problem hiding this comment.
Yeah it was reported a few times, mostly with users that set their username as "firstname lastname".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds using short path on Windows for the path to the model. This should eliminate any remaining Windows issues wrt to spaces in paths.
cleans up some of the code that that helped with some edge cases for earlier versions of cmdstan:
< 2.24For all these cases we should get rid of this code for maintanance reasons. Users should install 2.26+ when installing a new CmdStan.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: