Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global max_rows option for print method #470

Merged
merged 1 commit into from Mar 17, 2021
Merged

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Mar 16, 2021

closes #469

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Allows options(cmdstanr_max_rows = value) to set max_rows argument of print method for an entire R session (or until changing the option).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-io
Copy link

Codecov Report

Merging #470 (51fb1cd) into master (053a1ec) will decrease coverage by 1.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   93.42%   91.54%   -1.89%     
==========================================
  Files          12       12              
  Lines        2861     2861              
==========================================
- Hits         2673     2619      -54     
- Misses        188      242      +54     
Impacted Files Coverage Δ
R/fit.R 98.42% <100.00%> (ø)
R/install.R 61.56% <0.00%> (-10.63%) ⬇️
R/run.R 95.30% <0.00%> (-1.51%) ⬇️
R/utils.R 90.54% <0.00%> (-1.36%) ⬇️
R/model.R 91.12% <0.00%> (-1.17%) ⬇️
R/csv.R 98.16% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053a1ec...51fb1cd. Read the comment docs.

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion or rather an idea. Maybe we go with the name

cmdstanr.max_rows

I know brms uses options like brms.normalize and such. You are obviously the R packages expert here so you would know better than me what is more common.

@jgabry
Copy link
Member Author

jgabry commented Mar 17, 2021

Yeah I've seen both conventions used. I don't have a strong preference, I just used cmdstanr_max_rows to be consistent with the cmdstanr_verbose option that we already have.

@rok-cesnovar
Copy link
Member

Cool, if both are common then lets merge this.

@rok-cesnovar rok-cesnovar merged commit 7089393 into master Mar 17, 2021
@rok-cesnovar rok-cesnovar deleted the global-option-max-rows branch March 17, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global max_rows option for print method
3 participants