Handle tables in data #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgabry
commented
Jul 2, 2021
| @@ -76,19 +76,62 @@ test_that("JSON output for list of matrices is correct", { | |||
| file = test_path("answers", "json-matrix-lists.json")) | |||
| }) | |||
|
|
|||
| test_that("write_stan_json() throws correct errors", { | |||
There was a problem hiding this comment.
i split these tests up into separate tests for the different errors
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 92.78% 92.79% +0.01%
==========================================
Files 12 12
Lines 3035 3041 +6
==========================================
+ Hits 2816 2822 +6
Misses 219 219
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Closes #527 by removing the "table" class from tables.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: