Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_recompile global option #580

Merged
merged 4 commits into from Nov 1, 2021
Merged

Conversation

rok-cesnovar
Copy link
Member

Summary

Adds a global force_recompile option (cmdstanr_force_recompile) which can be useful for packages that use cmdstanr as a dependecy. In case of any issues, recompiling models typically can fix them (obviously we would want to fix them, but this is the next best thing).

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #580 (840a727) into master (622fa94) will decrease coverage by 1.16%.
The diff coverage is n/a.

❗ Current head 840a727 differs from pull request most recent head 0dcb430. Consider uploading reports for the commit 0dcb430 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   93.10%   91.93%   -1.17%     
==========================================
  Files          12       12              
  Lines        3233     3187      -46     
==========================================
- Hits         3010     2930      -80     
- Misses        223      257      +34     
Impacted Files Coverage Δ
R/model.R 92.64% <ø> (-0.42%) ⬇️
R/zzz.R 75.00% <0.00%> (-6.82%) ⬇️
R/install.R 64.68% <0.00%> (-5.35%) ⬇️
R/run.R 94.08% <0.00%> (-1.65%) ⬇️
R/utils.R 88.88% <0.00%> (-1.39%) ⬇️
R/csv.R 98.21% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622fa94...0dcb430. Read the comment docs.

@jgabry
Copy link
Member

jgabry commented Nov 1, 2021

Seems like a good idea. I think r cmd check is failing because of a warning related to the doc. You might just need to regenerate the Rd file and push it.

@rok-cesnovar
Copy link
Member Author

Indeed :) Pushed.

@rok-cesnovar
Copy link
Member Author

I guess this is good to go?

@jgabry
Copy link
Member

jgabry commented Nov 1, 2021

Yeah I'll merge now

@jgabry jgabry merged commit 9e41082 into master Nov 1, 2021
@jgabry jgabry deleted the add_force_recompile_global_option branch November 1, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants