Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model methods parameter naming and extract skeleton function #724

Merged
merged 2 commits into from Dec 3, 2022
Merged

Update model methods parameter naming and extract skeleton function #724

merged 2 commits into from Dec 3, 2022

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Following the discussion in #720, the argument names to the model methods have been updated for consistency with the rest of the package (i.e., pars -> variables, and upars -> unconstrained_variables).

Returning the variable skeleton for structuring draws has also been separated out to its own method: fit$variable_skeleton().

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #724 (b3373a3) into master (61c3079) will decrease coverage by 1.06%.
The diff coverage is 93.75%.

❗ Current head b3373a3 differs from pull request most recent head 2b54e4c. Consider uploading reports for the commit 2b54e4c to get more accurate results

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   88.36%   87.30%   -1.07%     
==========================================
  Files          12       12              
  Lines        4039     3993      -46     
==========================================
- Hits         3569     3486      -83     
- Misses        470      507      +37     
Impacted Files Coverage Δ
R/model.R 89.49% <ø> (-1.06%) ⬇️
R/fit.R 97.02% <93.75%> (-0.45%) ⬇️
R/install.R 57.89% <0.00%> (-4.12%) ⬇️
R/run.R 92.84% <0.00%> (-1.56%) ⬇️
R/utils.R 73.47% <0.00%> (-0.66%) ⬇️
R/csv.R 96.02% <0.00%> (-0.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrjohns
Copy link
Collaborator Author

@jgabry and @rok-cesnovar does this cover all of the API changes that you were thinking of? (I've also updated the examples so that they should run sorry!).

I'll be adding the suggested $unconstrain_draws() function in the next PR

@jgabry
Copy link
Member

jgabry commented Dec 2, 2022

@jgabry and @rok-cesnovar does this cover all of the API changes that you were thinking of?

Yeah I think so, thanks!

@andrjohns
Copy link
Collaborator Author

Now added a fix and test for the zero-length containers handling from #723, so this is now ready for review (assuming tests pass!)

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rok-cesnovar rok-cesnovar merged commit 3b65de8 into stan-dev:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants