Fix model$format and model$check_syntax for compiled models with include-paths #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
This PR fixes #774 by using
self$include_paths()
instead ofprivate$precompile_include_paths_
in the methodscheck_syntax
andformat
. This is because the latter only holds theinclude_paths
if the model has not been compiled yet. As a result, it is now possible to call these methods on compiled models with include statements without getting a syntax error fromstanc
. Forformat
, this has currently not been possible at all, forcheck_syntax
, you always had to use theinclude_paths
argument of the function even if the same, defaultinclude_paths
were used.The PR also adds tests for include_paths in
check_syntax
andformat
on compiled models, but I am not sure if these are desired as they require compilation of the example model during testing.This is my first PR for
cmdstanr
, so apologies in case I violated any conventions.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Adrian Lison
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: