Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init_model_methods for models with no data #801

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #793 by allowing the model methods to be initialised for models with no input data

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Merging #801 (26ca383) into master (e8fc2d3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 26ca383 differs from pull request most recent head 99bfe0f. Consider uploading reports for the commit 99bfe0f to get more accurate results

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   88.24%   88.27%   +0.02%     
==========================================
  Files          12       12              
  Lines        4160     4161       +1     
==========================================
+ Hits         3671     3673       +2     
+ Misses        489      488       -1     
Files Changed Coverage Δ
R/utils.R 73.70% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@andrjohns andrjohns merged commit 323c14d into master Jul 31, 2023
12 checks passed
@andrjohns andrjohns deleted the issue-793-model-methods branch July 31, 2023 14:45
@jgabry
Copy link
Member

jgabry commented Jul 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model errors after sampling if compiled with compile_model_methods = TRUE
4 participants