Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jacobian_adjustment argument to jacobian #879

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 17, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Closes #877

Deprecates argument jacobian_adjustment in favor of jacobian to be consistent with optimize and laplace. Based on feedback from @avehtari. This affects log_prob, grad_log_prob and hessian.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@jgabry
Copy link
Member Author

jgabry commented Nov 17, 2023

Making this PR against the prep-v0.7.0 branch to include it in next release

@jgabry
Copy link
Member Author

jgabry commented Nov 20, 2023

@andrjohns Are you ok with me changing the name for this argument in the methods you added?

@jgabry jgabry merged commit d593db2 into prep-v0.7.0 Dec 13, 2023
@jgabry jgabry deleted the rename_jacobian_adjustment branch December 13, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant