Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken link in opencl.Rmd #908

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Update broken link in opencl.Rmd #908

merged 1 commit into from
Jan 23, 2024

Conversation

eipi10
Copy link
Contributor

@eipi10 eipi10 commented Jan 23, 2024

Current link is broken. I've changed it to what appears to be the current correct link, but I'm not positive.

Submission Checklist

  • Run unit tests
  • [ x] Declare copyright holder and agree to license (see below)

Summary

Please describe the purpose of the pull request.

Purpose: Fix broken link in OpenCL Vignette.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Joel Schwartz

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Current link is broken. I've changed it to what appears to be the current correct link, but I'm not positive.
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks like the right link. I’ll let the unit tests run before merging even though this shouldn’t affect anything.

@jgabry
Copy link
Member

jgabry commented Jan 23, 2024

One test is failing that has nothing to do with this PR so I'm going to go ahead and merge this. We'll have to look into that test separately (it seems to have something to do with CmdStan's tol_rel_grad option when using optimize. Perhaps something changed in the recent release, not sure at the moment.)

@jgabry jgabry merged commit 2abc6ec into stan-dev:master Jan 23, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants