Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loo_model_weights naming for list of loo objects #217

Merged
merged 1 commit into from Mar 27, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Mar 25, 2023

fixes #165 by getting model names for loo_model_weights even if list of loo objects is only partially named

@avehtari Does this behave as expected now?

@codecov-commenter
Copy link

Codecov Report

Merging #217 (39cafc0) into master (1832085) will increase coverage by 0.04%.
The diff coverage is 88.88%.

❗ Current head 39cafc0 differs from pull request most recent head 8828a7d. Consider uploading reports for the commit 8828a7d to get more accurate results

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   93.05%   93.09%   +0.04%     
==========================================
  Files          30       30              
  Lines        2766     2768       +2     
==========================================
+ Hits         2574     2577       +3     
+ Misses        192      191       -1     
Impacted Files Coverage Δ
R/loo_model_weights.R 99.27% <87.50%> (+0.01%) ⬆️
R/loo_compare.R 95.83% <100.00%> (+1.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@avehtari avehtari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works now as expected.

@jgabry jgabry merged commit 1560636 into master Mar 27, 2023
6 checks passed
@jgabry jgabry deleted the fix-model-weights-names branch March 27, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loo_compare and loo_model_weights have different behavior for list argument
3 participants