Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Pareto k Inf if it is NA #224

Merged
merged 1 commit into from Jul 3, 2023
Merged

Conversation

topipa
Copy link
Collaborator

@topipa topipa commented Jul 1, 2023

This PR changes the handling of Pareto k values in edge cases. If Pareto k is NaN or NA, it will be changed to Inf, whereas previously it was done only for NaN. Based on the discussion in #222.

@codecov-commenter
Copy link

Codecov Report

Merging #224 (c36fb14) into master (fa4bc97) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c36fb14 differs from pull request most recent head 8b24265. Consider uploading reports for the commit 8b24265 to get more accurate results

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files          30       30           
  Lines        2777     2777           
=======================================
  Hits         2583     2583           
  Misses        194      194           
Impacted Files Coverage Δ
R/gpdfit.R 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@topipa topipa assigned jgabry and unassigned jgabry Jul 1, 2023
@topipa topipa requested a review from jgabry July 1, 2023 06:24
@jgabry
Copy link
Member

jgabry commented Jul 3, 2023

Thanks @topipa!

@jgabry jgabry merged commit 8b07d09 into stan-dev:master Jul 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants