Refactors (warning for cv_search, solution_terms, term fit)
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a bit unsafe (due to the existence of *function* `solution_terms()` which can give, for example, `length(solution_terms) == 1` even if no local object `solution_terms` exists, which was one of the reasons for issue stan-dev#173).
… should be thrown by the corresponding `predict()` method. All pre-defined `predict()` methods should perform such a check, so only `predict.subfit()` needs to be adapted. The corresponding warning in `proj_helper()` can therefore be removed, which also avoids a definition of a `solution_terms` object which is a bit unsafe (due to the existence of *function* `solution_terms()`). Besides, also move (and modify) a related test from `test_proj_pred.R` to `test_project.R` which is more appropriate there.
the plural is more appropriate and because in `subprd()`, there are two objects called `fit`).
submodel may (and usually will) consist of several fits, namely one per several projected draw. Furthermore, `sub_fit` may be confounded too easily with objects of class `subfit` (which are model fit objects based on `glm_ridge()` or `glm_elnet()`). The name "submodl" was chosen because it is currently unused, avoids any reference to the term "fit", and has the same number of characters as `sub_fit` (which makes replacement easier since no reflows and re-indentations are required).
…o easily with "subfit").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly:
project()$p_type#211 and Re-use of fitted submodels #168 (when these issues are resolved, this warning may be removed);solution_terms(this is a bit unsafe due to the existence of thesolution_terms()function which can give, for example,length(solution_terms) == 1even if no local objectsolution_termsexists, which was one of the reasons for issue Incorrectpct_solution_terms_cvifvalidate_search = FALSE#173);fitusually stood for several fits).See the commit messages for details.