Add cvrefbuilder
#271
Merged
Add cvrefbuilder
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence models in `.init_kfold_refmodel()`. This is needed for custom reference models, but also for `get_refmodel.brmsfit()` to be able to set `brms_seed` appropriately there. Also add element `projpred_k` to the subelements of `cvfits` to be able to infer `brms_seed`s in `brms::get_refmodel.brmsfit()` from these. This may also be helpful for custom `cvfits` and/or custom reference models. Also improve documentation for argument `dis` of `init_refmodel()` because this new `cvrefbuilder` argument allows to change argument `dis` for the K "refits" of a `datafit` (if the user actually desires it).
… K-fold CV. In particular, explain elements `omitted` and `projpred_k`.
…st for brms reference models, in particular also covering grouped K-fold CV for GLMMs (because of brms issue paul-buerkner/brms#1286). Also set `run_cvfits_all` to `FALSE` and change its behavior (now picking the first GLMM, if available). Also handle reproducibility in the `cvfits` test for rstanarm in a better way (exploiting argument `folds` of `rstanarm::kfold.stanreg()`).
the brms version allows it.
just a safety measure because `.Random.seed` could be redefined locally.
…ons" (simply because this is the more appropriate place).
…to ensure that arguments which are passed to `init_refmodel()` by the initial `get_refmodel.stanreg()` call are also passed to `init_refmodel()` by the K `get_refmodel.stanreg()` calls in K-fold CV. This is important for the latent and the augmented-data projection, for example. But it could also be useful for other arguments passed to `init_refmodel()`.
fweber144
force-pushed
the
cvrefbuilder
branch
from
781a001
to
3992196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is necessary in conjunction with PRs paul-buerkner/brms#1287 and paul-buerkner/brms#1290 to solve paul-buerkner/brms#1286. But as mentioned in the message of commit 09c7286, this is also necessary for some custom reference models.