Fix issue #268 #287
Merged
Fix issue #268 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new group-level effects are drawn when predicting from a multilevel submodel). Also adapt the docs.
|
I think your suggestions make sense |
|
I think what you've done here is fine, thanks for asking (I'll forward this to other lme4-authors in case they have strong opinions, but I'm pretty sure they'll be fine with this too). |
Great, thanks. |
|
I'm also happy with your attribution to us for the code reused from |
fweber144
added a commit
to fweber144/projpred
that referenced
this pull request
Mar 16, 2022
files `LICENSE` and `LICENSE.md`. File `LICENSE` contains some detailed information about external components (including their full license texts). The GPL-2 license text was downloaded from <https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt>. File `LICENSE.md` contains the full GPL-3 license text (as recommended at <https://r-pkgs.org/license.html#key-files>) and was downloaded from <https://www.gnu.org/licenses/gpl.md>.
files `LICENSE` and `LICENSE.md`. File `LICENSE` contains some detailed information about external components (including their full license texts). The GPL-2 license text was downloaded from <https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt>. File `LICENSE.md` contains the full GPL-3 license text (as recommended at <https://r-pkgs.org/license.html#key-files>) and was downloaded from <https://www.gnu.org/licenses/gpl.md>.
useful in the future).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #268 for GLMMs by drawing the random effects for new group levels from a (multivariate) Gaussian distribution.
Note that by this PR, issue #268 is not fixed for GAMMs yet.
Copyright/license:
The code for the new
repair_re.merMod()is inspired by (i.e., it uses code snippets from)lme4:::predict.merMod(). I included a corresponding statement right beforerepair_re.merMod()(these lines). Since lme4 is licensed under GPL (>=2) and projpred is licensed under GPL-3, the inclusion of code snippets from lme4 should be ok. (For a proof that GPL (>=2) and GPL-3 are compatible, see here and the table here.) However, some remaining questions I have are:LICENSEfile where we explain which code snippets from lme4 are used (and change the "License" field inDESCRIPTIONcorrespondingly toGPL-3 | file LICENSE)? This is what is done in package shiny, for example. (But I guess the external components in shiny are larger than the code snippets used here.)LICENSE.mdfile containing the full GPL-3 license text (see here)?DESCRIPTIONfile? If you would like such a copyright-holder entry in the "Authors@R" field, which persons should it include? Or simply "The LME4 Authors"?