Fix issue #149 #288
Closed
Fix issue #149 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically, the new `contrasts` argument is passed to argument `contrasts.arg` of the `model.matrix()` call within `fit_glm_ridge_callback()`).
contrasts (see `options("contrasts")`) anyway, we don't need to call it
(`contrasts.arg = NULL` in the `model.matrix()` call will also create the
default contrasts).
`collapse_contrasts_solution_path()` (the aim is to get rid of `get_contrasts_arg_list()`).
`fit_glm_ridge_callback()` because `predict.subfit()` first needs some adjustments (so it can also deal with user-specified contrasts).
default explicitly. Also name argument `data`.
This reverts commit 68f95c3. Reason: Deleting the response is actually necessary. Otherwise, errors like `Error in eval(predvars, data, env) : object '.y_glm_gauss.1' not found` are thrown.
predictors and update a related comment in the `penalty` test.
the intercept in case of a non-intercept-only model (for GLMs). This is a fixup for commit 5be4c57.
predictors are used more often.
predictors also in case of "special" formulas.
|
I'm just realizing that you might get a merge conflict despite my attempt to avoid this. If you do, then the final |
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #149. The main problem was in
fit_glm_ridge_callback()andget_contrasts_arg_list(), but some more changes were also necessary, in particular for L1 search.IMPORTANT: This PR should be merged after PR #287. To avoid a merge conflict when doing so, I included the
NEWSentryFix GitHub issue #268. (GitHub: #287)(which also exists at PR #287) here once again.