Avoid more transformations between latent space and response space #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link (latent) scale if there are no offsets. The reason is that at least for the binomial family, but possibly also for the Poisson family and any other families with non-identity (default) link functions, numerical inaccuracies can cause `link(linkinv(eta))` to be different from `eta`.
…cale, this time in `.get_p_clust()`. (See commit 321b399 for a reasoning.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following upon #337, this PR avoids even more unnecessary back-and-forth transformations between latent space and response space. Originally, the commits from this PR were performed on branch
fweber144:augdat(see PR #322), but they turned out to be useful for non-identity link functions in the traditional projection, too (see #337 and the commit messages here for some more details).