Fix #330 #344
Merged
Fix #330 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efficiency (this is an equivalent transformation because of `weights / sum(weights)` which is performed directly afterwards).
…common one. This is only a refactor.
…ommon one. This is only a refactor.
… `"auc"` to a common one. This is only a refactor (the lines `n_notna <- sum(d_test$weights)` and `weights <- n_notna * weights / sum(weights)` do not harm in case of the `"auc"` because the constant scalar factor `n_notna / sum(weights)` cancels out in `auc()`).
correct, but for consistency, it would have to be added to the `"acc"` (= `"pctcorr"`) case, too. And that would clutter the help page. But most importantly, it's quite obvious how AUC and accuracy are calculated in case of the "aggregated" binomial family.
correspondingly, element `<vsel_object>$summaries$<sub[[k]]_or_ref>$w` to `<vsel_object>$summaries$<sub[[k]]_or_ref>$wcv`) to avoid confusion in the future.
of the function definition. This seems to be an R convention. Enhance another inline comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #330 completely (commit 23e7101 already fixed it partly, i.e., as far as possible at that time).
Note that in contrast to what I assumed in the
TODOcomment added by 23e7101, theauc()function actually seems to have expected the CV fold weights in the third column of its input matrix. The user-supplied observation weights were simply ignored for the"auc"statistic before 23e7101.