Disallow offsets for datafits
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take offsets into account (but `<refmodel>$mu` contains the observed response values), see the comment at <stan-dev#186 (comment)>.
offsets-related code in the test "L1-projection with data reference gives the same results as Lasso from glmnet.". This reverts commit 7cb21617f5a55f74db39590e01f5da45cc1ed831.
|
Note that strangely, the test |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #186 (comment), this PR disallows offsets for
datafits because the submodel fitting does not take offsets into account (but<refmodel>$mucontains the observed response values which inevitably "include" the offsets, i.e., we cannot get (hypothetical) observed response values excluding offsets if offsets are actually present).