Pass digits of print.vselsummary() to print.data.frame()
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using it for `round()`. Thus, `digits` now determines the minimum number of *significant digits*.
fweber144
added a commit
to fweber144/projpred
that referenced
this pull request
Apr 2, 2023
via the ellipsis (`...`). This implies that by default, we now use `print.data.frame()`'s default for argument `digits` (which is `NULL`). This is an amendment to PR stan-dev#389.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using argument
digitsofprint.vselsummary()for determining the minimum number of significant digits is more natural than using it inround(). This is probably also the reason whyprint.data.frame()usesdigitsthat way. Thus, this PR switches from usingdigitsinround()to using it inprint.data.frame().See the commit messages and the newly added
NEWSentry for details.