Warn if L1 search selects an interaction before main effects #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts have been selected.
terms being selected before all involved main effects have been selected. Use this possibility in the tests. Currently, such a warning is not thrown during the tests, but it might be in the future.
selected before all involved main effects have been selected.
Need to set `options(projpred.warn_L1_interactions = TRUE)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #190 further (in addition to commit fweber144@abe2f48 from PR #233 which only addressed the documentation) in that we now throw a warning if an interaction term is selected before all involved main effects have been selected.