Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #211, at least in a quick way. Later, we may implement more of the suggestions from #211 (comment).
In the tests,
datafit
s will now haveproject()$p_type = FALSE
because fordatafit
s, we havenclusters = S = 1
, meaning thatget_refdist()
will call itself withndraws = 1
andnclusters = NULL
. The new behavior also means that fordatafit
s,proj_predict()
will not drawnresample_clusters
(default:1000
) times from the predictive distribution based on the same single projected draw.