Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend PR #406 #411

Merged
merged 12 commits into from
May 4, 2023
Merged

Amend PR #406 #411

merged 12 commits into from
May 4, 2023

Conversation

fweber144
Copy link
Collaborator

This amends PR #406 by essentially performing the following steps:

  1. Function cvfolds() is renamed to cv_folds(), for consistency with the cv_ prefix used in cv_varsel() and cv_ids().
  2. Function props() is renamed to cv_proportions().
  3. Function solution_terms() is deprecated.

Details may be found in the commit messages.

@fweber144
Rename cvfolds() to cv_folds().
e176ce1
@fweber144
Allow usage of the former function cvfolds() for a while, but depre…
cdfe6ac 
…cate it

(so we can remove it in a future release, at the latest in the major UI
overhaul).
@fweber144
Replace all occurrences of props with cv_proportions.
5ec94e1
@fweber144
Replace all occurrences of cumulcv_proportions with `cv_proportions…
267cef6 
…_cumul`.
@fweber144
Reflow/re-indent and replace all occurrences of cv_cv_proportions w…
e967d20 
…ith `cv_props`.
@fweber144
Replace all occurrences of cv_proportions_long with cv_props_long.
a5c917e
@fweber144
Replace all occurrences of ggcv_proportions with gg_cv_props.
f7d93f4
@fweber144
Insert GitHub PR number into the corresponding NEWS.md entries.
aff34f4
@fweber144
Deprecate solution_terms.vsel() because ranking() is now a more
3def851 
comprehensive replacement for it (and also because we'll avoid the term
"solution path" in the future).
@fweber144
Add function predictor_terms() and deprecate `solution_terms.projec…
7dcae8a 
…tion()`.
@fweber144
NEWS.md: Minor wording improvement.
c20c044
@fweber144
Docs: Enhance the deprecation warning for solution_terms() and its …
d23bcc2 
…methods.
@fweber144 fweber144 merged commit 09777c4 into stan-dev:master May 4, 2023
@fweber144 fweber144 deleted the rename_props_etc branch May 4, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fweber144