Default search method "forward"
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
measuring the runtime for the intercept-only projection (in `search_forward()`) and then scaling this up to estimate the runtime for the remaining search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the default search
methodis now"forward"search for all kinds of models (previously,"L1"search was used by default if available).The reason for this change is that in general, forward search is more favorable compared to L1 search (see section "Details" in
?varselor?cv_varsel).If forward search takes too long (currently: longer than 3 minutes), a message is thrown, mentioning the runtime estimate. This is done by measuring the runtime for the intercept-only projection (in
search_forward()) and then scaling this up to obtain an estimate of the runtime for the remaining search.