Add varsel.vsel() and cv_varsel.vsel()
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actually new methods which allow to re-use earlier search results.
…sel()` (and at that occasion, refine the `...` behavior of other `varsel()` and `cv_varsel()` methods as well).
(I experienced this with the `psisloo <- loo::psis(-loglik_forPSIS, cores = 1, r_eff = NA)` line). Furthermore, in the output, handle `search_terms` in the same way as `cvfits`.
… content of the main vignette.
…ture in section "Speed".
…n case of skipped model sizes.
"cv_varsel.vsel() (internally called with `validate_search = FALSE`) works for `vsel` objects from varsel()" is done now.
"varsel.vsel() works for `vsel` objects from cv_varsel() (called with `validate_search = FALSE`)" and "cv_varsel.vsel() (internally called with `validate_search = FALSE`) works for `vsel` objects from varsel()".
…size) doesn't make sense if the ranking of predictors involved in interactions has been changed, so we need to choose a higher `extra_tol` in that case.
fweber144
added a commit
that referenced
this pull request
Oct 23, 2023
Amend #461: Allow switching from `validate_search = TRUE` to `validate_search = FALSE` and partly prepare K-fold CV with `validate_search = FALSE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new methods
varsel.vsel()andcv_varsel.vsel()(in fact, these methods already existed before, but only as placeholders). With these methods, it is possible to re-use the search results from a previousvarsel()orcv_varsel()run, which is an important feature of the (unfortunately hopelessly outdated)workflowbranch.See the
NEWS.mdentry added here for some more information.