Make K-fold CV with validate_search = FALSE possible
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LSE` case to `cv_varsel.refmodel()` to avoid redundancies. This is possible because within `loo_varsel()`, only object `refmodel` was modified before calling performing the full-data search from `loo_varsel()`'s `validate_search = FALSE` case and there, only `refmodel$y` was modified, which is not relevant for the search. This internal change may cause LOO subsampling with clustered projection during the search to yield slightly different results due to different internal pseudorandom number generator (PRNG) states. Furthermore, if `is.na(seed)`, then the PRNG state for code downstream of such a `cv_varsel()` call will be different due to this change.
…"]]` out of `loo_varsel()` (makes it easier to combine this with similar code from K-fold CV).
…l()` more consistent.
…l()` even more consistent.
…` is possible now.
…search = FALSE`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use K-fold CV with
validate_search = FALSE. In order to implement this, it was easier to perform some refactoring first (commits be9b149 to 6a626c3) instead of relying on more "hacky" solutions.