Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include additional template imports to suppress NOTEs #115

Merged
merged 4 commits into from Sep 1, 2023

Conversation

andrjohns
Copy link
Collaborator

Any new packages created by rstantools will receive the following NOTE on CRAN submission:

N  checking dependencies in R code (904ms)
   Namespaces in Imports field not imported from:
     ‘RcppParallel’ ‘rstantools’
     All declared Imports should be used.

Because we add those packages to their package Imports but they only get used in the configure & Makevars, so their namespaces aren't imported from.

This PR resolves that by adding the following imports to the template structure:

importFrom(rstantools, rstan_config)
importFrom(RcppParallel, RcppParallelLibs)

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Feel free to merge once it passes.

@jgabry
Copy link
Member

jgabry commented Sep 1, 2023

I think this can close #99

@andrjohns andrjohns merged commit fcd263a into master Sep 1, 2023
6 checks passed
@jgabry jgabry deleted the additional-imports branch September 1, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants