Fix packages with stanfunctions under rstan 2.33+ #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgabry
approved these changes
Sep 11, 2023
|
@jgabry When you've got the time would you mind pushing a new release to CRAN? We'll need this change release for |
|
Thanks! Yeah I can do a release soon. I just got back from traveling abroad
for a few weeks and need to catch up on everything!
…On Sat, Jan 13, 2024 at 5:24 AM Andrew Johnson ***@***.***> wrote:
@jgabry <https://github.com/jgabry> When you've got the time would you
mind pushing a new release to CRAN? We'll need this change release for
lgpr and rmdcev to build with the next rstan/StanHeaders
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3PQQYKP2RINJM2QB6TQTLYOJ4JFAVCNFSM6AAAAAA4TEPDAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGQZTQNBWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No worries, there's no rush! |
|
I can get the ball rolling on this while catching up on other stuff. I'll start running reverse dependence checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a similar issue as this
cmdstanrPR: stan-dev/cmdstanr#847After 2.33
stanc3will emit plain types for standalone functions instead ofauto, so we no longer need to pre-process thehppto do this ourselves.This PR is needed for rstan 2.33 compatibility with packages like
lgprandrmdcevwhich export standalone functions during installation