feat: upgrade plugin & parser to v2.9.0 (#200)

BREAKING CHANGE: camelcase applies to generic types: https://github.com/typescript-eslint/typescript-eslint/pull/925/files?short_path=aaadf9e#diff-aaadf9e37107194e3f6679b2c8e30ec3 BREAKING CHANGE: restrict-plus-operands is applies to compound assignments: https://github.com/typescript-eslint/typescript-eslint/pull/892/files?short_path=d634f46#diff-d634f469dd550492a918f33b100f0734 BREAKING CHANGE: Add rule no-extra-non-null-assertion: https://github.com/typescript-eslint/typescript-eslint/pull/1183/files?short_path=ef83cd2#diff-ef83cd2743d5bd1f8c7b245fca0c1367 BREAKING CHANGE: Add rule prefer-nullish-coalescing: https://github.com/typescript-eslint/typescript-eslint/pull/1069/files?short_path=2bbcee3#diff-2bbcee3ab3b7eb9fcdeb1aabae22e177 BREAKING CHANGE: Add rule prefer-optional-chain: https://github.com/typescript-eslint/typescript-eslint/pull/1213/files?short_path=35a55a2#diff-35a55a2cbf3c835b088167bc2e912ee8 no-extraneous-class is relaxed to allow with decorator: https://github.com/typescript-eslint/typescript-eslint/pull/886/files?short_path=3696b44#diff-3696b44f524c94e3a48be3795feb09a6 Closes #179
mightyiam · Jan 16, 2020 · 2e770df · 2e770df
1 parent c6a948f
commit 2e770df
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -55,7 +55,7 @@
     "TypeScript"
   ],
   "dependencies": {
-    "@typescript-eslint/parser": "^2.8.0",
+    "@typescript-eslint/parser": "^2.9.0",
     "eslint-config-standard": "^14.1.0"
   },
   "peerDependencies": {
@@ -64,14 +64,14 @@
     "eslint-plugin-node": ">=9.1.0",
     "eslint-plugin-promise": ">=4.2.1",
     "eslint-plugin-standard": ">=4.0.0",
-    "@typescript-eslint/eslint-plugin": ">=2.8.0"
+    "@typescript-eslint/eslint-plugin": ">=2.9.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^8.2.0",
     "@commitlint/config-conventional": "^8.2.0",
     "@commitlint/travis-cli": "^8.2.0",
     "@types/node": "^13.1.0",
-    "@typescript-eslint/eslint-plugin": "^2.8.0",
+    "@typescript-eslint/eslint-plugin": "^2.9.0",
     "ava": "^2.4.0",
     "editorconfig-checker": "^3.0.3",
     "eslint": "^6.7.2",
@@ -84,7 +84,7 @@
     "read-pkg-up": "^7.0.1",
     "standard-version": "^7.0.1",
     "tsconfigs": "^4.0.2",
-    "typescript": "3.6.4"
+    "typescript": "3.7.4"
   },
   "files": [
     "lib/index.js",

diff --git a/src/index.test.ts b/src/index.test.ts
@@ -45,7 +45,7 @@ test('export', (t): void => {
           '@typescript-eslint/adjacent-overload-signatures': 'error',
           '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
           '@typescript-eslint/brace-style': ['error', '1tbs', { allowSingleLine: true }],
-          '@typescript-eslint/camelcase': ['error', { properties: 'never' }],
+          '@typescript-eslint/camelcase': ['error', { properties: 'never', genericType: 'always' }],
           '@typescript-eslint/consistent-type-assertions': [
             'error',
             {
@@ -86,7 +86,8 @@ test('export', (t): void => {
           '@typescript-eslint/no-dynamic-delete': 'error',
           '@typescript-eslint/no-empty-function': 'error',
           '@typescript-eslint/no-empty-interface': 'error',
-          '@typescript-eslint/no-extraneous-class': 'error',
+          '@typescript-eslint/no-extra-non-null-assertion': 'error',
+          '@typescript-eslint/no-extraneous-class': ['error', { allowWithDecorator: true }],
           '@typescript-eslint/no-floating-promises': 'error',
           '@typescript-eslint/no-for-in-array': 'error',
           '@typescript-eslint/no-misused-new': 'error',
@@ -101,10 +102,12 @@ test('export', (t): void => {
           '@typescript-eslint/no-useless-constructor': 'error',
           '@typescript-eslint/no-var-requires': 'error',
           '@typescript-eslint/prefer-function-type': 'error',
+          '@typescript-eslint/prefer-nullish-coalescing': ['error', { ignoreConditionalTests: false, ignoreMixedLogicalExpressions: false }],
+          '@typescript-eslint/prefer-optional-chain': 'error',
           '@typescript-eslint/prefer-readonly': 'error',
           '@typescript-eslint/promise-function-async': 'error',
           '@typescript-eslint/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
-          '@typescript-eslint/restrict-plus-operands': 'error',
+          '@typescript-eslint/restrict-plus-operands': ['error', { checkCompoundAssignments: true }],
           '@typescript-eslint/require-array-sort-compare': 'error',
           '@typescript-eslint/require-await': 'error',
           '@typescript-eslint/restrict-template-expressions': 'error',

diff --git a/src/index.ts b/src/index.ts
@@ -2,7 +2,6 @@ import { rules as standardRules } from 'eslint-config-standard/eslintrc.json'
 
 const equivalents = [
   'brace-style',
-  'camelcase',
   'indent',
   'no-array-constructor',
   'no-unused-vars',
@@ -32,6 +31,7 @@ export = {
 
         // Rules replaced by @typescript-eslint versions:
         ...fromEntries(equivalents.map((name) => [name, 'off'])),
+        camelcase: 'off',
         'no-use-before-define': 'off',
 
         // @typescript-eslint versions of Standard.js rules:
@@ -46,6 +46,7 @@ export = {
         // Rules exclusive to Standard TypeScript:
         '@typescript-eslint/adjacent-overload-signatures': 'error',
         '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
+        '@typescript-eslint/camelcase': ['error', { properties: 'never', genericType: 'always' }],
         '@typescript-eslint/consistent-type-assertions': [
           'error',
           {
@@ -70,7 +71,8 @@ export = {
         '@typescript-eslint/no-dynamic-delete': 'error',
         '@typescript-eslint/no-empty-function': 'error',
         '@typescript-eslint/no-empty-interface': 'error',
-        '@typescript-eslint/no-extraneous-class': 'error',
+        '@typescript-eslint/no-extra-non-null-assertion': 'error',
+        '@typescript-eslint/no-extraneous-class': ['error', { allowWithDecorator: true }],
         '@typescript-eslint/no-floating-promises': 'error',
         '@typescript-eslint/no-for-in-array': 'error',
         '@typescript-eslint/no-misused-new': 'error',
@@ -81,11 +83,13 @@ export = {
         '@typescript-eslint/no-unnecessary-type-assertion': 'error',
         '@typescript-eslint/no-var-requires': 'error',
         '@typescript-eslint/prefer-function-type': 'error',
+        '@typescript-eslint/prefer-nullish-coalescing': ['error', { ignoreConditionalTests: false, ignoreMixedLogicalExpressions: false }],
+        '@typescript-eslint/prefer-optional-chain': 'error',
         '@typescript-eslint/prefer-readonly': 'error',
         '@typescript-eslint/promise-function-async': 'error',
         '@typescript-eslint/require-array-sort-compare': 'error',
         '@typescript-eslint/require-await': 'error',
-        '@typescript-eslint/restrict-plus-operands': 'error',
+        '@typescript-eslint/restrict-plus-operands': ['error', { checkCompoundAssignments: true }],
         '@typescript-eslint/restrict-template-expressions': 'error',
         '@typescript-eslint/strict-boolean-expressions': 'error',
         '@typescript-eslint/triple-slash-reference': ['error', { lib: 'never', path: 'never', types: 'never' }],