Skip to content

Commit

Permalink
feat: pin eslint-config-standard dependency
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the dependency eslint-config-standard is now pinned.

closes #849

Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
  • Loading branch information
mightyiam and rostislav-simonik committed Jun 27, 2022
1 parent c8baf6d commit 5bbd534
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
],
"dependencies": {
"@typescript-eslint/parser": "^5.0.0",
"eslint-config-standard": "^17.0.0"
"eslint-config-standard": "17.0.0"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^5.0.0",
Expand Down
11 changes: 5 additions & 6 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,11 @@ const isPinnedRange = (rangeStr: string): boolean => {

test('Dependencies range types', async (t) => {
const { ourDeps, ourPeerDeps, ourDevDeps } = await getPkgDetails()
for (const [name, range] of Object.entries(ourDeps)) {
t.true(
isSingleCaretRange(range),
`Regular dependency \`${name}: ${range}\` is a single \`^\` range.`
)
}

t.deepEqual(Object.keys(ourDeps).sort(), ['@typescript-eslint/parser', 'eslint-config-standard'])
t.true(isPinnedRange(ourDeps['eslint-config-standard']), 'eslint-config-standard is pinned')
t.true(isSingleCaretRange(ourDeps['@typescript-eslint/parser']), '@typescript-eslint/parser is a single `^` range.')

for (const [name, range] of Object.entries(ourPeerDeps)) {
if (name === 'typescript') {
t.is(range, '*', 'Peer dependency typescript is `*`')
Expand Down

0 comments on commit 5bbd534

Please sign in to comment.