Our config to not be under the overrides property #1149
Labels
Comments
This was referenced May 30, 2023
|
Hello, I wonder why you make this decision. Is it related to ESLint v9 with the new config file format? 🤓 Regards. |
|
Nah, it's not inspired by that. I don't even know what that change includes. #43 was never a good idea because it is implemented using the overrides feature with a filename extensions pattern. That is way too specific and stepping outside of the scope of this package. Specifically, it prevents users from applying this config to whatever arbitrary filename extensions they may wish to apply it to. |
mightyiam
added a commit
that referenced
this issue
Jun 30, 2023
BREAKING CHANGE: the rules are provided at the top level, instead of under an `overrides` property. Providing the rules under the `overrides` property was never a good idea. It prevents specifying which files the rules apply to (e.g. `[*.js, *.ts]`). I apologise. To migrate, make sure that your `extends` property is under an [`overrides` item][overrides]. An example is in the readme. To help verify your configuration, you could obtain a list of files that will be linted, this way: `DEBUG=eslint:cli-engine npx eslint <path>`. overrides: https://eslint.org/docs/latest/use/configure/configuration-files#how-do-overrides-work closes #1149 closes #1088 Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
rostislav-simonik
added a commit
that referenced
this issue
Jun 30, 2023
BREAKING CHANGE: the rules are provided at the top level, instead of under an `overrides` property. Providing the rules under the `overrides` property was never a good idea. It prevents specifying which files the rules apply to (e.g. `[*.js, *.ts]`). I apologize. To migrate, make sure that your `extends` property is under an [`overrides` item][overrides]. An example is in the readme. To help verify your configuration, you could obtain a list of files that will be linted, this way: `DEBUG=eslint:cli-engine npx eslint <path>`. [overrides]: https://eslint.org/docs/latest/use/configure/configuration-files#how-do-overrides-work closes #1149 closes #1088 Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
standard-cd-bot bot
pushed a commit
that referenced
this issue
Jun 30, 2023
## [36.0.0](v35.0.0...v36.0.0) (2023-06-30) ### ⚠ BREAKING CHANGES * the rules are provided at the top level, instead of under an `overrides` property. Providing the rules under the `overrides` property was never a good idea. It prevents specifying which files the rules apply to (e.g. `[*.js, *.ts]`). I apologize. To migrate, make sure that your `extends` property is under an [`overrides` item][overrides]. An example is in the readme. To help verify your configuration, you could obtain a list of files that will be linted, this way: `DEBUG=eslint:cli-engine npx eslint <path>`. [overrides]: https://eslint.org/docs/latest/use/configure/configuration-files#how-do-overrides-work ### Bug fixes * rules are at top level (not under overrides) ([25401c9](25401c9)), closes [#1149](#1149) [#1088](#1088)
|
🎉 This issue has been resolved in version 36.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#43 was never a good idea. We mean to revert it, probably as a breaking change.
This happens to be the highest priority issue at this time.
The text was updated successfully, but these errors were encountered: