Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include rule prefer-includes #148

Closed
mightyiam opened this issue Sep 23, 2019 · 2 comments · Fixed by #225
Closed

Include rule prefer-includes #148

mightyiam opened this issue Sep 23, 2019 · 2 comments · Fixed by #225

Comments

@mightyiam
Copy link
Owner

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-includes.md
@toddbluhm
Copy link
Contributor

toddbluhm commented Nov 22, 2019 •
edited

I think this is a good rule to add. My only concern is people writing pre-es2015 code. But then again if they are writing pre-es2015 code they probably are not using this configuration anyways.

@mightyiam
Copy link
Owner Author

@toddbluhm thank you for your suggestion. I agree that this should be included. Would you like to PR?

toddbluhm added a commit to toddbluhm/eslint-config-standard-with-typescript that referenced this issue Feb 9, 2020
@toddbluhm
feat(rules): add rule prefer-includes (mightyiam#148)
67c36eb 
BREAKING CHANGE: add rule prefer-includes:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-includes.md
@toddbluhm toddbluhm mentioned this issue Feb 9, 2020
Merged
4 tasks
mightyiam pushed a commit that referenced this issue Feb 10, 2020
@toddbluhm
feat(rules): add rule prefer-includes (#148) (#225)
a2bdac5 
BREAKING CHANGE: add rule prefer-includes:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/prefer-includes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rules): add rule prefer-includes (#148) toddbluhm/eslint-config-standard-with-typescript
2 participants
@toddbluhm @mightyiam