Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func-call-spacing and comma-dangle can cause un-fixable error #232

Closed
felskov opened this issue Feb 18, 2020 · 2 comments · Fixed by #234
Closed

func-call-spacing and comma-dangle can cause un-fixable error #232

felskov opened this issue Feb 18, 2020 · 2 comments · Fixed by #234

Comments

@felskov
Copy link
Contributor

felskov commented Feb 18, 2020

In the following example, I'm getting an error from func-call-spacing:

const map = new Map<string, () => void>()

Auto-fixing results in the following code, which throws an error from comma-dangle:

const map = new Map<string,() => void>()

What version of this package are you using?
13.0.0

What problem do you want to solve?
Avoid having un-fixable errors using out-of-the-box configuration

What do you think is the correct solution to this problem?
Use @typescript-eslint/func-call-spacing instead of eslint built-in func-call-spacing.

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/func-call-spacing.md

Are you willing to submit a pull request to implement this change?
Yes

@LinusU
Copy link
Contributor

LinusU commented Feb 18, 2020

Use @typescript-eslint/func-call-spacing instead of eslint built-in func-call-spacing.

This sounds great, PR welcome 🙌

@felskov
Copy link
Contributor Author

felskov commented Feb 18, 2020

@LinusU #234

@mightyiam mightyiam linked a pull request Feb 18, 2020 that will close this issue
felskov added a commit to felskov/eslint-config-standard-with-typescript that referenced this issue Feb 18, 2020
BREAKING CHANGE: new rule @typescript-eslint/func-call-spacing

fixes mightyiam#232
mightyiam pushed a commit that referenced this issue Feb 18, 2020
BREAKING CHANGE: new rule @typescript-eslint/func-call-spacing

fixes #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants