fix: ensure @typescript-eslint/semi rule is applied #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
approved these changes
Apr 21, 2020
mightyiam
requested changes
Apr 21, 2020
There was a problem hiding this comment.
Thank you, @bengourley. I'm not sure how I missed this one.
Co-Authored-By: Shahar Dawn Or <mightyiampresence@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added
@typescript-eslint/semito the list of equivalent rules.Which issue (if any) does this pull request address?
Consistent semi-colon usage was not being applied to TypeScript code when linting with this config.
Is there anything you'd like reviewers to focus on?
There may be other equivalent packages I haven't noticed. I only added the one I was knowingly being affected by, but there may be a better way to ensure the equivalents don't get out of date.