Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript should be a peerDependency #286

Closed
mightyiam opened this issue Apr 23, 2020 · 0 comments · Fixed by #287
Closed

typescript should be a peerDependency #286

mightyiam opened this issue Apr 23, 2020 · 0 comments · Fixed by #287

Comments

@mightyiam
Copy link
Owner

As mentioned here: #285 (review).

The parser and plugin do not specify it. Even if they did, ours could possibly be higher?

https://github.com/typescript-eslint/typescript-eslint/blob/4ef67884962b6aac61cc895aaa3ba16aa892ecf4/packages/eslint-plugin/package.json#L58-L61

https://github.com/typescript-eslint/typescript-eslint/blob/4ef67884962b6aac61cc895aaa3ba16aa892ecf4/packages/parser/package.json#L41-L43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: specify typescript as peerDep mightyiam/eslint-config-love
1 participant
@mightyiam