Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version node 0.8.0 #10

Closed
tusharmath opened this issue Apr 9, 2016 · 3 comments
Closed

Support version node 0.8.0 #10

tusharmath opened this issue Apr 9, 2016 · 3 comments
Labels

Comments

@tusharmath
Copy link

I know its a very old version but a lot of legacy projects in production are using 0.8. When they try to move to standard, their builds start to fail For example in node-config/node-config#307 the standard integration breaks the build — https://travis-ci.org/lorenwest/node-config/builds/121860743

Its I think because of the way inherits works for different versions of node.

@feross feross closed this as completed in fadb3ed Apr 11, 2016
@feross
Copy link
Member

feross commented Apr 11, 2016

No problem. This was as simple as using require('readable-stream') instead of require('stream') since node 0.8 doesn't support streams2.

Released as 3.0.1.

@feross feross added the bug label Apr 11, 2016
@tusharmath
Copy link
Author

@feross I am not sure if this will fix the problem. Check the stack trace —

> standard | snazzy
util.js:538
  ctor.prototype = Object.create(superCtor.prototype, {
                                          ^
TypeError: Cannot read property 'prototype' of undefined
    at exports.inherits (util.js:538:43)
    at Object.<anonymous> (/home/travis/build/lorenwest/node-config/node_modules/snazzy/index.js:9:1)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:362:17)
    at require (module.js:378:17)
    at Object.<anonymous> (/home/travis/build/lorenwest/node-config/node_modules/snazzy/bin/cmd.js:3:30)
    at Module._compile (module.js:449:26)

@feross
Copy link
Member

feross commented Apr 22, 2016

Sorry, can't think of any reason why this won't work. Make sure you're actually using the latest version of snazzy. Otherwise, you're welcome to send a PR to fix this and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants